Merge legacy.js and main.mjs into main.js #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o-
approved these changes
Apr 4, 2024
|
@camillobruni I didn't look closely, but it seems like this potentially broke dark mode. Could you have a look, please? |
camillobruni
added a commit
that referenced
this pull request
Apr 4, 2024
This reverts commit 3f113cb.
|
Ups right, I accidentally removed the dark-mode import... planned to replace this with some simpler logic. |
|
Filed #758 as a reminder. Thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no advantage of using modules over classic scripts if there are no imports.
We currently have the legacy script as a nomodule fallback, we can merge them easily into a single main.js script and simplify the page a bit.